feat(core): Turn Rspack incremental on by default (again) #10800
+108
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: -2.45 kB (-0.02%) Total Size: 11.7 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Hmmm nop, it doesn't work and crashes whenever I create a new MDX file (editing an existing one works though): Might be related to web-infra-dev/rspack#8480 |
|
Size Change: +217 B (0%) Total Size: 12.1 MB ℹ️ View Unchanged
|
|
Incremental has been fixed in Considering 1.1.9 is not planned (web-infra-dev/rspack#8480 (comment)) I'm going to pin that alpha version for now until v1.2 becomes stable. Note: I tested the new persistent cache but it's not working well enough for me to include for now. It's faster but I encountered bugs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This tries again to turn on Rspack incremental rebuilds:
https://rspack.dev/blog/announcing-1-1#new-incremental-rebuild
We initially shipped in v3.6, this but encountered issues and had to revert:
#10646 (comment)
#10712
@hardfist advised us:
As far as I understand, incremental has been released in Rspress v1.38 2 weeks ago:
I didn't see any Rspress issue related to it, so it looks fine to turn it on by default in Docusaurus too considering we also add an env variable to disable it in case of problems (pass
DISABLE_RSPACK_INCREMENTAL=true), and it will only affect sites that opted-in to use Rspack (while by default sites are using Webpack)Test Plan
CI + local
Test links
https://deploy-preview-10800--docusaurus-2.netlify.app/